Review Request: Fetch contacts only when contactManager is ready + connection Fix.

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102106/#review5216
-----------------------------------------------------------

Ship it!


Arbitrary line breaks are arbitrary (at the end of the diff).

But seriously, this looks fine.

- George


On July 27, 2011, 9:06 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102106/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 9:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fetch contacts only when contactManager is ready.
> 
> 
> Replace monitoring of connectionStatusChanged with connectionChanged as these are not always directly in sync.
> 
> This prevents a potential crash using Account::connection() when it doesn't exist.
> 
> 
> Diffs
> -----
> 
>   account.h 265fb86f6f5cde9d5f314136873dc5f95eff0c7a 
>   account.cpp 79d5ec6ac42afd1c935c8625c1f9e6a1b53ef8d1 
> 
> Diff: http://git.reviewboard.kde.org/r/102106/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110729/09fbca01/attachment-0001.htm