Review Request: Fetch contacts only when contactManager is ready + connection Fix.

David Edmundson kde at davidedmundson.co.uk
Wed Jul 27 23:06:29 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102106/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Fetch contacts only when contactManager is ready.


Replace monitoring of connectionStatusChanged with connectionChanged as these are not always directly in sync.

This prevents a potential crash using Account::connection() when it doesn't exist.


Diffs
-----

  account.h 265fb86f6f5cde9d5f314136873dc5f95eff0c7a 
  account.cpp 79d5ec6ac42afd1c935c8625c1f9e6a1b53ef8d1 

Diff: http://git.reviewboard.kde.org/r/102106/diff


Testing
-------


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110727/47290ffb/attachment.htm 


More information about the KDE-Telepathy mailing list