Review Request: Allow tabs to be dettached from window

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101862/#review4439
-----------------------------------------------------------


I think it is good, but I'd like someone else to take a look as I'm not too familiar with this code. If no-one will by the end of the week, just ship it.


app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101862/#comment3742>

    This can be null action if user presses Esc for example. So add a check for this pointer.



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101862/#comment3743>

    Please take this comment out of the for loop ;)



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101862/#comment3744>

    Watch for coding style - void ChatWindow::removeTab(ChatTab* tab)



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101862/#comment3745>

    Shouldn't you delete the 'tab' here instead of chatWidget?



app/telepathy-chat-ui.h
<http://git.reviewboard.kde.org/r/101862/#comment3746>

    Some whitespace leftover



app/telepathy-chat-ui.h
<http://git.reviewboard.kde.org/r/101862/#comment3747>

    ...and here as well..



app/telepathy-chat-ui.cpp
<http://git.reviewboard.kde.org/r/101862/#comment3748>

    ...and couple more here and below ;)


- Martin


On July 6, 2011, 5:24 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101862/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 5:24 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Okay, internet's really sketchy here - I don't have time to type a long description. 
> 
> I'm not sure I handled the result from KMenu::exec() right, but apart form that my changes *should* be fairly straightforward in the diff.
> 
> http://quickgit.kde.org/?p=clones%2Ftelepathy-chat-handler%2Ffernando%2FdetachableTabs.git&a=shortlog&h=refs/heads/refractored_tabs
> 
> 
> Diffs
> -----
> 
>   app/chat-tab.h 2175fe2 
>   app/chat-tab.cpp 23c912e 
>   app/chat-window.h 2b2b70d 
>   app/chat-window.cpp 517b694 
>   app/telepathy-chat-ui.h 306912d 
>   app/telepathy-chat-ui.cpp 1654a9d 
> 
> Diff: http://git.reviewboard.kde.org/r/101862/diff
> 
> 
> Testing
> -------
> 
> Detached a few conversations with friends. 
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110706/5ce3689e/attachment-0001.htm