Review Request: Allow tabs to be dettached from window

[David Edmundson]

> On July 6, 2011, 9:42 a.m., Martin Klapetek wrote:
> > I think it is good, but I'd like someone else to take a look as I'm not too familiar with this code. If no-one will by the end of the week, just ship it.

I should be able to find time. 


> On July 6, 2011, 9:42 a.m., Martin Klapetek wrote:
> > app/chat-window.cpp, line 189
> > <http://git.reviewboard.kde.org/r/101862/diff/1/?file=26130#file26130line189>
> >
> >     Shouldn't you delete the 'tab' here instead of chatWidget?

this is deleting the tab, just variable is named wrong.
Also (and I know this isn't your code) it should be chatWidget->deleteLater();


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101862/#review4439
-----------------------------------------------------------


On July 6, 2011, 5:24 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101862/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 5:24 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Okay, internet's really sketchy here - I don't have time to type a long description. 
> 
> I'm not sure I handled the result from KMenu::exec() right, but apart form that my changes *should* be fairly straightforward in the diff.
> 
> http://quickgit.kde.org/?p=clones%2Ftelepathy-chat-handler%2Ffernando%2FdetachableTabs.git&a=shortlog&h=refs/heads/refractored_tabs
> 
> 
> Diffs
> -----
> 
>   app/chat-tab.h 2175fe2 
>   app/chat-tab.cpp 23c912e 
>   app/chat-window.h 2b2b70d 
>   app/chat-window.cpp 517b694 
>   app/telepathy-chat-ui.h 306912d 
>   app/telepathy-chat-ui.cpp 1654a9d 
> 
> Diff: http://git.reviewboard.kde.org/r/101862/diff
> 
> 
> Testing
> -------
> 
> Detached a few conversations with friends. 
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110706/31e17320/attachment.htm