Review Request: Allow tabs to be dettached from window

Lasath Fernando kde at lasath.org
Wed Jul 6 07:24:55 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101862/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Okay, internet's really sketchy here - I don't have time to type a long description. 

I'm not sure I handled the result from KMenu::exec() right, but apart form that my changes *should* be fairly straightforward in the diff.

http://quickgit.kde.org/?p=clones%2Ftelepathy-chat-handler%2Ffernando%2FdetachableTabs.git&a=shortlog&h=refs/heads/refractored_tabs


Diffs
-----

  app/chat-tab.h 2175fe2 
  app/chat-tab.cpp 23c912e 
  app/chat-window.h 2b2b70d 
  app/chat-window.cpp 517b694 
  app/telepathy-chat-ui.h 306912d 
  app/telepathy-chat-ui.cpp 1654a9d 

Diff: http://git.reviewboard.kde.org/r/101862/diff


Testing
-------

Detached a few conversations with friends. 


Thanks,

Lasath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110706/071db7fb/attachment.htm 


More information about the KDE-Telepathy mailing list