Review Request: Various cleanups in the chat handler

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100460/#review1126
-----------------------------------------------------------

Ship it!


Being honest, I'm struggling to read that amount of diff, but it looks a lot more consistent with KDE libs.
Given the former code has never been reviewed, it doesn't make much sense to pick on your changes.

- David


On Jan. 30, 2011, 10:07 p.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100460/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2011, 10:07 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Summary
> -------
> 
> This includes various cleanups and coding style/policy fixes in the chat handler.
> 
> shortlog:
> George Kiagiadakis (3):
>       Remove the ChatConnection class and use tp-qt4 factories instead.
>       Various coding style and policy related fixes.
>       Remove the now unneeded updateEnabledState() function in ChatWindow.
> 
> http://quickgit.kde.org/?p=clones/telepathy-chat-handler/gkiagia/telepathy-chat-handler.git&a=shortlog&h=refs/heads/cleanups
> 
> 
> Diffs
> -----
> 
>   adiumxtra-protocol-handler/adiumxtraprotocolhandler.h 4f088dd0a0038736ec0b499d7b8d5d3153e00449 
>   adiumxtra-protocol-handler/adiumxtraprotocolhandler.cpp 2c935cc344316f301ff262cc68bdc0b1543ffa77 
>   adiumxtra-protocol-handler/bundleinstaller.h aa8420a819f528f8f784773f3ff8e0d5aa7b9b06 
>   adiumxtra-protocol-handler/bundleinstaller.cpp ebc11e172568a9c4203f65ad77faacd018cd83b2 
>   adiumxtra-protocol-handler/chatstyleinstaller.h af8e8281752e7219808dfc2f0c684eff871bba0e 
>   adiumxtra-protocol-handler/chatstyleinstaller.cpp d0f9a0ad9d0d0e9fb2428db5988712c93a3741b1 
>   adiumxtra-protocol-handler/emoticonsetinstaller.h bbac6491b54a0020240216220b34447921661091 
>   adiumxtra-protocol-handler/emoticonsetinstaller.cpp d6b66c087b982355e5caba7e9463755f6be8ef2c 
>   adiumxtra-protocol-handler/main.cpp 083634beed8fbe0c031b276816261bf4a4912ac1 
>   app/main.cpp 9f572a6bdee33f76739777a294aa29f83783a12d 
>   app/mainwindow.h bffa82915b18a7c217d7f8284283f9f1420d35ec 
>   app/mainwindow.cpp 98647c9cbf3bd3456c9fc79ab8acb048dad393e0 
>   config/mainwindow.h 282c8e1104b0eb19bf39dea98fcd4b9651130dbd 
>   config/mainwindow.cpp 48dcb2af97936270858ee8475ec94ea758036864 
>   lib/CMakeLists.txt 2ea0a3a903e7fbeb06590a93b373521ea804337e 
>   lib/adiumthemecontentinfo.h e3c60d97277b638f10764a9cc35d956bb5e0b2f0 
>   lib/adiumthemecontentinfo.cpp 748dd25386d200ab91304f72ff8c295dacb4fbca 
>   lib/adiumthemeheaderinfo.h 0bb77ce4461790cb7264e9ce521054d2fc29f34f 
>   lib/adiumthemeheaderinfo.cpp 6a0a54372944967b268c85108b98d58bbece8265 
>   lib/adiumthememessageinfo.cpp 16408ef4af62eded2876955dbda33fe0fe18114b 
>   lib/adiumthemestatusinfo.h 03ad082a27c34370d96c7be55a7bce63a243b6c8 
>   lib/adiumthemestatusinfo.cpp 5b223d504c351a3dd6df485b86efe936063ebea6 
>   lib/adiumthemeview.h 9833b5b42e4d0539bc9491ede0238ab804ea0e82 
>   lib/adiumthemeview.cpp 6d3226fabb4e7737675a554e3c9f00203887fc2e 
>   lib/channelcontactlist.h f3fae069081febf3c5471bd8b74708f1ec72ec93 
>   lib/channelcontactlist.cpp 499ae802d10990179a3f3c97d0f09639024df0b2 
>   lib/chatconnection.h 70ddcdc8a3c375ee527d0af8303b4e2a9d8a6980 
>   lib/chatconnection.cpp 07521fae157d2b78fc3134c23a4a8d4c181869de 
>   lib/chatstyleplistfilereader.h fef007a397b974f9f306c826b8ddb9f08b5ef81d 
>   lib/chatstyleplistfilereader.cpp 96bead483dca5d12640de423b8bc6f54e2496bf2 
>   lib/chattextedit.h 40e943258d538a34750e989366f6b108211d6297 
>   lib/chattextedit.cpp 28b3b1404944015d03bc5b74131dea2c144272ae 
>   lib/chatwindow.h 434ece2946daeace4b93fafb14a8a67aa718e4c0 
>   lib/chatwindow.cpp 92e7a5329f6a1ed00634aa28ce6dfe3590ace6a5 
>   lib/chatwindowstyle.h 9ad9e962e18308b09de1e71a9a7a77efd3834087 
>   lib/chatwindowstyle.cpp e9e23815be3577be788085ba6706ca1bb45ed729 
>   lib/chatwindowstylemanager.h 350a6126c7d5677f2eefe9ebe066a182b8b6cb66 
>   lib/chatwindowstylemanager.cpp 826ab36f939c0bb632dd098aa3fee5d12beaffe6 
> 
> Diff: http://git.reviewboard.kde.org/r/100460/diff
> 
> 
> Testing
> -------
> 
> compiles and works like before.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110130/c2416a41/attachment-0001.htm