Review Request: Some bug fixes for the chat handler

George Kiagiadakis kiagiadakis.george at gmail.com
Sun Jan 30 23:07:39 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100461/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Summary
-------

shortlog:
George Kiagiadakis (5):
      Fix the contactPresenceChanged signal to actually notify us about presence changes.
      Let mainwindow know the correct chat window icon from the beggining of the session.
      Fix the presence change messages.
      Catch contact alias changes.
      Do not show notifications about messages that have already been shown by the approver.

http://quickgit.kde.org/?p=clones/telepathy-chat-handler/gkiagia/telepathy-chat-handler.git&a=shortlog&h=refs/heads/fixes


Diffs
-----

  app/mainwindow.cpp 98647c9cbf3bd3456c9fc79ab8acb048dad393e0 
  lib/channelcontactlist.h f3fae069081febf3c5471bd8b74708f1ec72ec93 
  lib/channelcontactlist.cpp 499ae802d10990179a3f3c97d0f09639024df0b2 
  lib/chatwindow.h 434ece2946daeace4b93fafb14a8a67aa718e4c0 
  lib/chatwindow.cpp 92e7a5329f6a1ed00634aa28ce6dfe3590ace6a5 

Diff: http://git.reviewboard.kde.org/r/100461/diff


Testing
-------

All changes have been tested, except the remote contact's alias change.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110130/05601c9f/attachment.htm 


More information about the KDE-Telepathy mailing list