<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100460/">http://git.reviewboard.kde.org/r/100460/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Being honest, I'm struggling to read that amount of diff, but it looks a lot more consistent with KDE libs.
Given the former code has never been reviewed, it doesn't make much sense to pick on your changes.</pre>
<br />
<p>- David</p>
<br />
<p>On January 30th, 2011, 10:07 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2011, 10:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This includes various cleanups and coding style/policy fixes in the chat handler.
shortlog:
George Kiagiadakis (3):
Remove the ChatConnection class and use tp-qt4 factories instead.
Various coding style and policy related fixes.
Remove the now unneeded updateEnabledState() function in ChatWindow.
http://quickgit.kde.org/?p=clones/telepathy-chat-handler/gkiagia/telepathy-chat-handler.git&a=shortlog&h=refs/heads/cleanups</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works like before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>adiumxtra-protocol-handler/adiumxtraprotocolhandler.h <span style="color: grey">(4f088dd0a0038736ec0b499d7b8d5d3153e00449)</span></li>
<li>adiumxtra-protocol-handler/adiumxtraprotocolhandler.cpp <span style="color: grey">(2c935cc344316f301ff262cc68bdc0b1543ffa77)</span></li>
<li>adiumxtra-protocol-handler/bundleinstaller.h <span style="color: grey">(aa8420a819f528f8f784773f3ff8e0d5aa7b9b06)</span></li>
<li>adiumxtra-protocol-handler/bundleinstaller.cpp <span style="color: grey">(ebc11e172568a9c4203f65ad77faacd018cd83b2)</span></li>
<li>adiumxtra-protocol-handler/chatstyleinstaller.h <span style="color: grey">(af8e8281752e7219808dfc2f0c684eff871bba0e)</span></li>
<li>adiumxtra-protocol-handler/chatstyleinstaller.cpp <span style="color: grey">(d0f9a0ad9d0d0e9fb2428db5988712c93a3741b1)</span></li>
<li>adiumxtra-protocol-handler/emoticonsetinstaller.h <span style="color: grey">(bbac6491b54a0020240216220b34447921661091)</span></li>
<li>adiumxtra-protocol-handler/emoticonsetinstaller.cpp <span style="color: grey">(d6b66c087b982355e5caba7e9463755f6be8ef2c)</span></li>
<li>adiumxtra-protocol-handler/main.cpp <span style="color: grey">(083634beed8fbe0c031b276816261bf4a4912ac1)</span></li>
<li>app/main.cpp <span style="color: grey">(9f572a6bdee33f76739777a294aa29f83783a12d)</span></li>
<li>app/mainwindow.h <span style="color: grey">(bffa82915b18a7c217d7f8284283f9f1420d35ec)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(98647c9cbf3bd3456c9fc79ab8acb048dad393e0)</span></li>
<li>config/mainwindow.h <span style="color: grey">(282c8e1104b0eb19bf39dea98fcd4b9651130dbd)</span></li>
<li>config/mainwindow.cpp <span style="color: grey">(48dcb2af97936270858ee8475ec94ea758036864)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(2ea0a3a903e7fbeb06590a93b373521ea804337e)</span></li>
<li>lib/adiumthemecontentinfo.h <span style="color: grey">(e3c60d97277b638f10764a9cc35d956bb5e0b2f0)</span></li>
<li>lib/adiumthemecontentinfo.cpp <span style="color: grey">(748dd25386d200ab91304f72ff8c295dacb4fbca)</span></li>
<li>lib/adiumthemeheaderinfo.h <span style="color: grey">(0bb77ce4461790cb7264e9ce521054d2fc29f34f)</span></li>
<li>lib/adiumthemeheaderinfo.cpp <span style="color: grey">(6a0a54372944967b268c85108b98d58bbece8265)</span></li>
<li>lib/adiumthememessageinfo.cpp <span style="color: grey">(16408ef4af62eded2876955dbda33fe0fe18114b)</span></li>
<li>lib/adiumthemestatusinfo.h <span style="color: grey">(03ad082a27c34370d96c7be55a7bce63a243b6c8)</span></li>
<li>lib/adiumthemestatusinfo.cpp <span style="color: grey">(5b223d504c351a3dd6df485b86efe936063ebea6)</span></li>
<li>lib/adiumthemeview.h <span style="color: grey">(9833b5b42e4d0539bc9491ede0238ab804ea0e82)</span></li>
<li>lib/adiumthemeview.cpp <span style="color: grey">(6d3226fabb4e7737675a554e3c9f00203887fc2e)</span></li>
<li>lib/channelcontactlist.h <span style="color: grey">(f3fae069081febf3c5471bd8b74708f1ec72ec93)</span></li>
<li>lib/channelcontactlist.cpp <span style="color: grey">(499ae802d10990179a3f3c97d0f09639024df0b2)</span></li>
<li>lib/chatconnection.h <span style="color: grey">(70ddcdc8a3c375ee527d0af8303b4e2a9d8a6980)</span></li>
<li>lib/chatconnection.cpp <span style="color: grey">(07521fae157d2b78fc3134c23a4a8d4c181869de)</span></li>
<li>lib/chatstyleplistfilereader.h <span style="color: grey">(fef007a397b974f9f306c826b8ddb9f08b5ef81d)</span></li>
<li>lib/chatstyleplistfilereader.cpp <span style="color: grey">(96bead483dca5d12640de423b8bc6f54e2496bf2)</span></li>
<li>lib/chattextedit.h <span style="color: grey">(40e943258d538a34750e989366f6b108211d6297)</span></li>
<li>lib/chattextedit.cpp <span style="color: grey">(28b3b1404944015d03bc5b74131dea2c144272ae)</span></li>
<li>lib/chatwindow.h <span style="color: grey">(434ece2946daeace4b93fafb14a8a67aa718e4c0)</span></li>
<li>lib/chatwindow.cpp <span style="color: grey">(92e7a5329f6a1ed00634aa28ce6dfe3590ace6a5)</span></li>
<li>lib/chatwindowstyle.h <span style="color: grey">(9ad9e962e18308b09de1e71a9a7a77efd3834087)</span></li>
<li>lib/chatwindowstyle.cpp <span style="color: grey">(e9e23815be3577be788085ba6706ca1bb45ed729)</span></li>
<li>lib/chatwindowstylemanager.h <span style="color: grey">(350a6126c7d5677f2eefe9ebe066a182b8b6cb66)</span></li>
<li>lib/chatwindowstylemanager.cpp <span style="color: grey">(826ab36f939c0bb632dd098aa3fee5d12beaffe6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100460/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>