Review Request: Support drag and drop file transfer

Dominik Cermak d.cermak at arcor.de
Fri Dec 23 17:43:55 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/
-----------------------------------------------------------

(Updated Dec. 23, 2011, 5:43 p.m.)


Review request for Telepathy.


Changes
-------

Added new method requestFileTransferChannels, moved dropIndicatorRect to private class and fixed braces.


Description
-------

Adds support for drag and drop file transfer.
Before the model handled the drag and drop of contacts between groups,
but with reimplementing the drag*Event methods this stopped working so I moved the logic in the view.
(I will later clean up the model, I'm sure now there is unused code.)


This addresses bug 288560.
    http://bugs.kde.org/show_bug.cgi?id=288560


Diffs (updated)
-----

  contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
  contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 
  contact-list-widget_p.h 9f9914616be89884f5d2971782fa0c3cf20d3ac0 

Diff: http://git.reviewboard.kde.org/r/103520/diff/diff


Testing
-------

Drag and dropping contacts to groups works.
Dropping one or more local file(s) over a contact starts the filetransfer(s).


Thanks,

Dominik Cermak

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111223/f6a88f74/attachment.html>


More information about the KDE-Telepathy mailing list