Review Request: Support drag and drop file transfer

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/#review9230
-----------------------------------------------------------

Ship it!


Ok, I'm pretty happy with his. 
I'd like you to clarify with Martin about that final comment I had in the last email (about the drops).

One other thing I'd like to fix (though it can be after this commit) is adding a setDragDropMode in the constructor of ContactListWidget. 
I don't want (when you delete the relevant code from the models) having it marked as draggable in the model (in itemFlags), but the actual drag code being here. It should all be merged here.


contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/103520/#comment7641>

    minor pedant thing:
    
    if () {
    
    }


- David Edmundson


On Dec. 23, 2011, 5:43 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103520/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 5:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds support for drag and drop file transfer.
> Before the model handled the drag and drop of contacts between groups,
> but with reimplementing the drag*Event methods this stopped working so I moved the logic in the view.
> (I will later clean up the model, I'm sure now there is unused code.)
> 
> 
> This addresses bug 288560.
>     http://bugs.kde.org/show_bug.cgi?id=288560
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
>   contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 
>   contact-list-widget_p.h 9f9914616be89884f5d2971782fa0c3cf20d3ac0 
> 
> Diff: http://git.reviewboard.kde.org/r/103520/diff/diff
> 
> 
> Testing
> -------
> 
> Drag and dropping contacts to groups works.
> Dropping one or more local file(s) over a contact starts the filetransfer(s).
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111224/d4553c4d/attachment.html>