Review Request: Support drag and drop file transfer

[David Edmundson]

> On Dec. 23, 2011, 3:58 p.m., David Edmundson wrote:
> > contact-list-widget.cpp, line 652
> > <http://git.reviewboard.kde.org/r/103520/diff/1/?file=44645#file44645line652>
> >
> >     Important!
> >     
> >     I think you need to check which model we're showing at the time of the drop.
> >     
> >     If you're in the accounts model instead of the groups model this will just break. You'll be constantly adding contacts to group "".
> 
> Dominik Cermak wrote:
>     I yor're in the accounts model you won't get until here...
>     because in dragMoveEvent I only accept if index.data(AccountsModel::ItemRole).canConvert<GroupsModelItem*>() is true.
>     If you're not in groups model this will never be true and Qt won't let you drop the item.

Oh, I didn't see this, my fault.
Though this is changing the functionality. Previously you could drag anywhere in the group to add to the group, in your implementation can only drag onto group headers.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103520/#review9206
-----------------------------------------------------------


On Dec. 23, 2011, 5:43 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103520/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 5:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds support for drag and drop file transfer.
> Before the model handled the drag and drop of contacts between groups,
> but with reimplementing the drag*Event methods this stopped working so I moved the logic in the view.
> (I will later clean up the model, I'm sure now there is unused code.)
> 
> 
> This addresses bug 288560.
>     http://bugs.kde.org/show_bug.cgi?id=288560
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 85cac2a3912b127589757d95a32c64fa40444979 
>   contact-list-widget.cpp 3d4362442eb37577fcf067b1bd24daa80222b196 
>   contact-list-widget_p.h 9f9914616be89884f5d2971782fa0c3cf20d3ac0 
> 
> Diff: http://git.reviewboard.kde.org/r/103520/diff/diff
> 
> 
> Testing
> -------
> 
> Drag and dropping contacts to groups works.
> Dropping one or more local file(s) over a contact starts the filetransfer(s).
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111224/f0156b94/attachment-0001.html>