Review Request: Force window to be raised if a special hint is set in the channel request.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102484/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Force window to be raised if a special hint is set in the channel request.

This is to be used as a workaround to https://bugs.kde.org/show_bug.cgi?id=275266

The forceWindowActive() method is a bit naughty, and unsafe to just casually start inserting into the code. Especially with the TextUi sometimes ensuring channels back on itself.

This allows us to work round the issue by allowing the Contact List (or anyone else who wanted it) to tell the TextUi that it's ok to force itself on top of the other windows.

There is a companion update for the contact list to set this hint when creating text channels.

In doing this I uncovered a bug in TpQt4 - this is going to be fixed, probably in a release tomorrow.


Diffs
-----

  app/telepathy-chat-ui.h 3d2001588a073215fe90d3816d5b9ab8c3cd2144 
  app/telepathy-chat-ui.cpp 5473394ef4020bf4f02f304296df9214a18d988a 

Diff: http://git.reviewboard.kde.org/r/102484/diff


Testing
-------


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110829/3c8c5e65/attachment.html>