<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102484/">http://git.reviewboard.kde.org/r/102484/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Force window to be raised if a special hint is set in the channel request.
This is to be used as a workaround to https://bugs.kde.org/show_bug.cgi?id=275266
The forceWindowActive() method is a bit naughty, and unsafe to just casually start inserting into the code. Especially with the TextUi sometimes ensuring channels back on itself.
This allows us to work round the issue by allowing the Contact List (or anyone else who wanted it) to tell the TextUi that it's ok to force itself on top of the other windows.
There is a companion update for the contact list to set this hint when creating text channels.
In doing this I uncovered a bug in TpQt4 - this is going to be fixed, probably in a release tomorrow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/telepathy-chat-ui.h <span style="color: grey">(3d2001588a073215fe90d3816d5b9ab8c3cd2144)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(5473394ef4020bf4f02f304296df9214a18d988a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102484/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>