Review Request: Replace built-in tabs with KWin's

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102271/#review5597
-----------------------------------------------------------


I wasn't sure what to make of this patch so I went and found Martin Grasslin (the KWin guy) to get his opinion.

He told me that it was a bad idea to do this. Grouping can be disabled by a user, only works with some window decoration themes, and obviously not all the window managers. He also argued that you get a memory overhead/slowdowns from having lots of windows which kwin has to deal with.

Sorry.

It's worth joining our mailing list to discuss ideas up front, I hate seeing effort like this go to waste.


- David


On Aug. 9, 2011, 7:57 p.m., Lewandowski Janusz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102271/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 7:57 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I've removed all tab-related code, so now every chat has its own window, and added KWin rules to automatically group these windows. Resulting code is much cleaner and lighter (-380 lines), and we don't waste space - tabs are now integrated in the title bar (like in Chrome) and not in another bar.
> 
> 
> Diffs
> -----
> 
>   app/chat-tab.cpp 62c3c10 
>   app/chat-window.h 0f25ab0 
>   app/chat-tab.h 9b5fc59 
>   app/chat-window.cpp 9f37beb 
>   app/main.cpp df0b4f7 
>   app/telepathy-chat-ui.h f3cab67 
>   app/telepathy-chat-ui.cpp 71c2503 
>   data/CMakeLists.txt 6187d40 
>   data/kwin_telepathy_kde_text_ui.upd PRE-CREATION 
>   data/telepathy_kde_text_ui.kwinrules PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102271/diff
> 
> 
> Testing
> -------
> 
> I tested it for a day and there were no problems.
> 
> 
> Thanks,
> 
> Lewandowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110811/849d7125/attachment.html>