<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102271/">http://git.reviewboard.kde.org/r/102271/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wasn't sure what to make of this patch so I went and found Martin Grasslin (the KWin guy) to get his opinion.
He told me that it was a bad idea to do this. Grouping can be disabled by a user, only works with some window decoration themes, and obviously not all the window managers. He also argued that you get a memory overhead/slowdowns from having lots of windows which kwin has to deal with.
Sorry.
It's worth joining our mailing list to discuss ideas up front, I hate seeing effort like this go to waste.
</pre>
<br />
<p>- David</p>
<br />
<p>On August 9th, 2011, 7:57 p.m., Lewandowski Janusz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lewandowski Janusz.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 7:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've removed all tab-related code, so now every chat has its own window, and added KWin rules to automatically group these windows. Resulting code is much cleaner and lighter (-380 lines), and we don't waste space - tabs are now integrated in the title bar (like in Chrome) and not in another bar.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it for a day and there were no problems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-tab.cpp <span style="color: grey">(62c3c10)</span></li>
<li>app/chat-window.h <span style="color: grey">(0f25ab0)</span></li>
<li>app/chat-tab.h <span style="color: grey">(9b5fc59)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(9f37beb)</span></li>
<li>app/main.cpp <span style="color: grey">(df0b4f7)</span></li>
<li>app/telepathy-chat-ui.h <span style="color: grey">(f3cab67)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(71c2503)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(6187d40)</span></li>
<li>data/kwin_telepathy_kde_text_ui.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/telepathy_kde_text_ui.kwinrules <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102271/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>