Review Request: Replace built-in tabs with KWin's

Lewandowski Janusz lew21 at xtreeme.org
Tue Aug 9 19:57:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102271/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

I've removed all tab-related code, so now every chat has its own window, and added KWin rules to automatically group these windows. Resulting code is much cleaner and lighter (-380 lines), and we don't waste space - tabs are now integrated in the title bar (like in Chrome) and not in another bar.


Diffs
-----

  app/chat-tab.cpp 62c3c10 
  app/chat-window.h 0f25ab0 
  app/chat-tab.h 9b5fc59 
  app/chat-window.cpp 9f37beb 
  app/main.cpp df0b4f7 
  app/telepathy-chat-ui.h f3cab67 
  app/telepathy-chat-ui.cpp 71c2503 
  data/CMakeLists.txt 6187d40 
  data/kwin_telepathy_kde_text_ui.upd PRE-CREATION 
  data/telepathy_kde_text_ui.kwinrules PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102271/diff


Testing
-------

I tested it for a day and there were no problems.


Thanks,

Lewandowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110809/dbcc7a98/attachment.html>


More information about the KDE-Telepathy mailing list