Review Request: Disable the chat tab when the channel is invalidated
Lasse Liehu
lliehu at kolumbus.fi
Wed Apr 13 10:23:10 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101105/
-----------------------------------------------------------
(Updated April 13, 2011, 8:23 a.m.)
Review request for Telepathy.
Changes
-------
Made suggested changes
Summary
-------
I'm not sure about the message, but there should be some. Ideas about a better message are really appreciated. I'm also not sure if the line:
statusMessage.setService(d->channel->connection()->protocolName());
is good or not. I don't know what "service" is used for.
This addresses bug 270725.
http://bugs.kde.org/show_bug.cgi?id=270725
Diffs (updated)
-----
lib/chat-widget.h fdf5ccd
lib/chat-widget.cpp af7edff
Diff: http://git.reviewboard.kde.org/r/101105/diff
Testing
-------
1. Open a text chat with someone
2. Chat
3. Go offline (don't close the chat window/tab)
4. Send message line edit and button are disabled, informational message is shown
Thanks,
Lasse
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110413/71545804/attachment.htm
More information about the KDE-Telepathy
mailing list