Review Request: Disable the chat tab when the channel is invalidated

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101105/#review2615
-----------------------------------------------------------

Ship it!


Looks good, ship it.

Quick comment to watch out for in future, you've mixed in a change from one of your other commits which isn't part of this review. Very easy mistake to make.


lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101105/#comment2288>

    In future make sure you do each change in a separate branch. It means you can commit one fix without waiting on another. (and you don't mix up your reviews!)


- David


On April 13, 2011, 8:23 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101105/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 8:23 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I'm not sure about the message, but there should be some. Ideas about a better message are really appreciated. I'm also not sure if the line:
> statusMessage.setService(d->channel->connection()->protocolName());
> is good or not. I don't know what "service" is used for.
> 
> 
> This addresses bug 270725.
>     http://bugs.kde.org/show_bug.cgi?id=270725
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h fdf5ccd 
>   lib/chat-widget.cpp af7edff 
> 
> Diff: http://git.reviewboard.kde.org/r/101105/diff
> 
> 
> Testing
> -------
> 
> 1. Open a text chat with someone
> 2. Chat
> 3. Go offline (don't close the chat window/tab)
> 4. Send message line edit and button are disabled, informational message is shown
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110413/43bcb6e8/attachment.htm