Review Request: Disable the chat tab when the channel is invalidated

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101105/#review2595
-----------------------------------------------------------



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101105/#comment2270>

    a slot doesn't have to have the same number of arguments as a signal (it can't have more though) so given you aren't using the arguments you could just have
    
    onInvalidated();
    
    Whilst I'm making a comment
    onChannelInvalidated might be better.
    
    



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101105/#comment2271>

    This message is a bit wordy.
    
    I think a simple "Connection Closed" might be enough. They'll figure the rest out.
    
    Plus we'll fix it so it restores when it can soon(hopefully)


- David


On April 12, 2011, 3:10 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101105/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 3:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I'm not sure about the message, but there should be some. Ideas about a better message are really appreciated. I'm also not sure if the line:
> statusMessage.setService(d->channel->connection()->protocolName());
> is good or not. I don't know what "service" is used for.
> 
> 
> This addresses bug 270725.
>     http://bugs.kde.org/show_bug.cgi?id=270725
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h fdf5ccd 
>   lib/chat-widget.cpp af7edff 
> 
> Diff: http://git.reviewboard.kde.org/r/101105/diff
> 
> 
> Testing
> -------
> 
> 1. Open a text chat with someone
> 2. Chat
> 3. Go offline (don't close the chat window/tab)
> 4. Send message line edit and button are disabled, informational message is shown
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/c0cf81d5/attachment.htm