Review Request: Close the find bar in text-ui by pressing Esc

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101094/#review2574
-----------------------------------------------------------

Ship it!


Patch looks fine.

Except we now have 3 completely separated key trapping in this code.

ChatWidget has an eventFilter on anything in the ChatTextEdit looking for the return key
ChatTextEdit has a filter on itself looking for the Cntrl+F key
And now ChatWidget has another filter (this time on itself) checking for the escape key.

I'm pretty sure all of these could be one filter, or at most 2.

Ship what you've got if you like, but make sure we remember to sort this.

- David


On April 11, 2011, 11:19 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101094/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 11:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> When Esc is pressed, closes the find bar in current tab if it's visible.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h 3973326 
>   lib/chat-widget.cpp af7edff 
> 
> Diff: http://git.reviewboard.kde.org/r/101094/diff
> 
> 
> Testing
> -------
> 
> That the find bar in current tab closes by pressing Esc and that Esc behaviour of context menus and input methods works fine.
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/05dc764f/attachment.htm