Review Request: Close the find bar in text-ui by pressing Esc

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101094/#review2576
-----------------------------------------------------------



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101094/#comment2251>

    I'd put this inside of chat-text-edit.cpp @ line 75 where there is already an ovverriden method for the KeyPressEvent.
    This because the focus is of the lineEdit in the chat widget.


- Francesco


On April 11, 2011, 11:19 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101094/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 11:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> When Esc is pressed, closes the find bar in current tab if it's visible.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h 3973326 
>   lib/chat-widget.cpp af7edff 
> 
> Diff: http://git.reviewboard.kde.org/r/101094/diff
> 
> 
> Testing
> -------
> 
> That the find bar in current tab closes by pressing Esc and that Esc behaviour of context menus and input methods works fine.
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/45235367/attachment.htm