<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101094/">http://git.reviewboard.kde.org/r/101094/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch looks fine.
Except we now have 3 completely separated key trapping in this code.
ChatWidget has an eventFilter on anything in the ChatTextEdit looking for the return key
ChatTextEdit has a filter on itself looking for the Cntrl+F key
And now ChatWidget has another filter (this time on itself) checking for the escape key.
I'm pretty sure all of these could be one filter, or at most 2.
Ship what you've got if you like, but make sure we remember to sort this.</pre>
<br />
<p>- David</p>
<br />
<p>On April 11th, 2011, 11:19 p.m., Lasse Liehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated April 11, 2011, 11:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When Esc is pressed, closes the find bar in current tab if it's visible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That the find bar in current tab closes by pressing Esc and that Esc behaviour of context menus and input methods works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/chat-widget.h <span style="color: grey">(3973326)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(af7edff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101094/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>