Review Request: Lighter color for status message; show presence type if status message is not set

Martin Klapetek martin.klapetek at gmail.com
Sun Apr 10 12:22:17 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101066/#review2541
-----------------------------------------------------------



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101066/#comment2229>

    The "Online" string is useless here, this is uniquely represented by the status icon.



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101066/#comment2230>

    This shouldn't be "Away", but more like "Not available" or something. Anyone objects to "Not available"? If nobody comments here, change it to "Not available".



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101066/#comment2231>

    Same as online, don't use "Offile" here as it is obvious.


- Martin


On April 9, 2011, 12:43 p.m., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101066/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 12:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Lighter color for status message
> Show presence type if status message is not set
> 
> 
> Diffs
> -----
> 
>   contact-delegate.cpp 89514d2 
> 
> Diff: http://git.reviewboard.kde.org/r/101066/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101066/s/119/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110410/e071c50c/attachment-0001.htm 


More information about the KDE-Telepathy mailing list