Review Request: Lighter color for status message; show presence type if status message is not set

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Mon Apr 18 16:58:25 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101066/#review2725
-----------------------------------------------------------



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101066/#comment2393>

    Also "Tp::ConnectionPresenceTypeAway",  "Tp::ConnectionPresenceTypeExtendedAway" and "Tp::ConnectionPresenceTypeBusy" are uniquely represented by the status icon, therefore my suggestion is to cut this part and just leave the line empty if the user didn't set any message...


- Daniele Elmo


On April 9, 2011, 12:43 p.m., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101066/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 12:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Lighter color for status message
> Show presence type if status message is not set
> 
> 
> Diffs
> -----
> 
>   contact-delegate.cpp 89514d2 
> 
> Diff: http://git.reviewboard.kde.org/r/101066/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101066/s/119/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110418/2bbfc419/attachment.htm 


More information about the KDE-Telepathy mailing list