Review Request: Lighter color for status message; show presence type if status message is not set

[Martin Klapetek]

> On April 9, 2011, 4:45 p.m., David Edmundson wrote:
> > contact-delegate.cpp, line 123
> > <http://git.reviewboard.kde.org/r/101066/diff/1/?file=14065#file14065line123>
> >
> >     Not sure this is 100% right. 
> >     
> >     You've changed the color to be lighter. However, when it starts fading the color goes back to being QPalette::WindowText and then starts changing the alpha. 
> >     
> >     Which means when it fades it will start off grey (it's normal color), then go to black before fading.

Yes, this caught my eye as well, I suggest you set the fadingColor directly as m_palette->color(QPalette::WindowText).lighter(350) and then leave and use only the fadingColor


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101066/#review2518
-----------------------------------------------------------


On April 9, 2011, 12:43 p.m., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101066/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 12:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Lighter color for status message
> Show presence type if status message is not set
> 
> 
> Diffs
> -----
> 
>   contact-delegate.cpp 89514d2 
> 
> Diff: http://git.reviewboard.kde.org/r/101066/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101066/s/119/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110410/af7d8401/attachment.htm