Review Request: Adds tooltips and avatar button support

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2339
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/101012/#comment2027>

    Yes, I was thinking about the same, but I'm not entirely convinced that it should be part of the delegate (arch-wise) as the delegate just paints stuff, the popups should be handled by the widget IMHO. But, if we can do this more easily and cleanly with overriding helpEvent, then go for it. 



main-widget.cpp
<http://git.reviewboard.kde.org/r/101012/#comment2026>

    This looks much better now. But you should create a proper table - right now, you create a table with just one row. You should avoid using br/ and use tr instead, ie. create new table row. Then you'd have to also probably use a rowspan option on the avatar's cell. Please fix this :)


- Martin


On April 3, 2011, 4:06 a.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 4:06 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>     - Added support for tooltips when hovering over a contact in the list.
>     - Added support for the avatar button at the top of the contact list.
>       Now it will load the avatar when connecting, though I'm not sure on
>       how to handle it if a protocol changed the avatar outside of telepathy.
>       If the avatar is big it will resize it, so you don't have a huge tooltip
>       when you hover your accounts.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7581f10 
>   main-widget.h daa6559 
>   main-widget.cpp f65d7fd 
> 
> Diff: http://git.reviewboard.kde.org/r/101012/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110403/ae86297d/attachment.htm