Review Request: Adds tooltips and avatar button support

[David Edmundson]

> On April 3, 2011, 9:38 a.m., Martin Klapetek wrote:
> > main-widget.cpp, line 601
> > <http://git.reviewboard.kde.org/r/101012/diff/2/?file=13712#file13712line601>
> >
> >     Yes, I was thinking about the same, but I'm not entirely convinced that it should be part of the delegate (arch-wise) as the delegate just paints stuff, the popups should be handled by the widget IMHO. But, if we can do this more easily and cleanly with overriding helpEvent, then go for it.

The widget still launches the tooltip, it just delegates how to draw it to the delegate.

Conceptually it makes sense, you're overriding how to present the information in the model to a user. A tooltip is no different from painting a row in that regard.

More importantly - Qt API leads you to doing it here, otherwise the method wouldn't exist.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2339
-----------------------------------------------------------


On April 3, 2011, 4:06 a.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 4:06 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>     - Added support for tooltips when hovering over a contact in the list.
>     - Added support for the avatar button at the top of the contact list.
>       Now it will load the avatar when connecting, though I'm not sure on
>       how to handle it if a protocol changed the avatar outside of telepathy.
>       If the avatar is big it will resize it, so you don't have a huge tooltip
>       when you hover your accounts.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7581f10 
>   main-widget.h daa6559 
>   main-widget.cpp f65d7fd 
> 
> Diff: http://git.reviewboard.kde.org/r/101012/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110403/699e6734/attachment.htm