Review Request: Adds tooltips and avatar button support

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2335
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/101012/#comment2025>

    Code all looks ok, except I think it's in the wrong place.
    
    To me it would be better to have this in the ContactDelegate, overiding this method:
    http://doc.trolltech.com/4.7/qabstractitemdelegate.html#helpEvent
    
    This will only happen when you should show a tool tip after a tiny delay, not as soon as you mouse over.
    
    Also you may as well take as much data from the model as possible 
    i.e alias  = index.data(AccountsModel::AliasRole);
    
    (you can get stuff on the account with 
    index.parent().data(AccountsModel::SomethingForTheAccount) )
    
    It will make it super easy to be modified for meta contact stuff in the future.
    
    


- David


On April 3, 2011, 4:06 a.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 4:06 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>     - Added support for tooltips when hovering over a contact in the list.
>     - Added support for the avatar button at the top of the contact list.
>       Now it will load the avatar when connecting, though I'm not sure on
>       how to handle it if a protocol changed the avatar outside of telepathy.
>       If the avatar is big it will resize it, so you don't have a huge tooltip
>       when you hover your accounts.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7581f10 
>   main-widget.h daa6559 
>   main-widget.cpp f65d7fd 
> 
> Diff: http://git.reviewboard.kde.org/r/101012/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110403/dd0f7a98/attachment.htm