Review Request: A telepathy all-in-one widget

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4208/
-----------------------------------------------------------

Review request for telepathy, Dario Freddi and gruendeblog.


Summary
-------

This is the widget that I'm using to make GUI tests with Telepathy StreamTubes...

It is a QComboBox that queries Nepomuk and that can work in 3 modalities
1) DisplayModeAccounts (Shows all IMAccounts owned by "myself")
2) DisplayModeContacts (Shows all PersonContacts that are buddies for accounts owned by "myself")
3) DisplayModeMetaContacts (Should show all Persons, but it doesn't work yet)

It allows to filter contacts with the chosen Tp::ConnectionPresenceTypes.

It also offers some useful methods to retrieve the current resource:

- virtual Nepomuk::IMAccount currentAccount();
- virtual Nepomuk::PersonContact currentContact();
- virtual Nepomuk::Person currentMetaContact();
- virtual Nepomuk::Variant currentResource();

Finally it shows the correct status icon. :)

It is not finished yet:
- DisplayModeAccounts and DisplayModeContacts works correctly, but DisplayModeMetaContacts doesn't.
- It doesn't update when ConnectionPresences change.
- current* methods don't check if resources are of the correct type.
- There are probably a lot bugs and ugly stuff scattered around the code. ;)
- Documentation is completely missing.

Anyway it might be useful for someone, and I don't want to spend too much time on this at the moment, in order to focus on StreamTubes, so I'm waiting for comments, suggestions and patches! :D


Diffs
-----

  /trunk/playground/network/telepathy-contactlist/ktelepathyaccountswidget-test.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/ktelepathyaccountswidget.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/ktelepathyaccountswidget.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/ktelepathyaccountswidget_p.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/4208/diff


Testing
-------

ktelepathyaccountwidget-test.cpp is a test for the widget, just change lines 63 and 64 to change working modes...
I'm also successfully using it in my StreamTubes tests.


Screenshots
-----------

Telepathy widget in use
  http://reviewboard.kde.org/r/4208/s/414/
Telepathy widget test
  http://reviewboard.kde.org/r/4208/s/415/


Thanks,

Daniele E.