Review Request: Start basic metacontacts support in tp-contactlist

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3650/
-----------------------------------------------------------

(Updated 2010-04-22 17:49:14.328725)


Review request for telepathy and George Goldberg.


Changes
-------

Remove previous hack as now Nepomuk works. Fixed a pair of bugs, and now everything works happily as expected!

Protip: the model resets way too often. Maybe a better way of updating it?


Summary (updated)
-------

This patch adds basic metacontacts support to tp-contactlist. You can now add a contact to a metacontact, and have them grouped under it.

This required some tweaks to the existing queries (hey, I'm mastering SPARQL!), now the main contact query really excludes contacts belonging to a metacontact. Also, you can just specify the name of a metacontact.

To avoid Nepomuk crashing hard on you, use latest soprano release, >= 2.4.3.

Overall, it looks to me a decent start: the system already basically works.


Diffs (updated)
-----

  /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1117162 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.h 1117162 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.cpp 1117162 
  /trunk/playground/network/telepathy-contactlist/main-widget.h 1117162 
  /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1117162 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1117162 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1117162 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp 1117162 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.h 1117162 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp 1117162 

Diff: http://reviewboard.kde.org/r/3650/diff


Testing
-------

Tp-contactlist handles metacontacts decently, see screenshot.


Screenshots
-----------

Seeing is believing
  http://reviewboard.kde.org/r/3650/s/365/


Thanks,

Dario