Review Request: Start basic metacontacts support in tp-contactlist

Dario Freddi drf54321 at
Wed Apr 21 21:40:08 CEST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-04-21 19:40:07.816514)

Review request for telepathy and George Goldberg.


Implementing metacontact removal, and implementing all the neat stuff we discussed with Sebastian.

This patch triggers a serious Nepomuk problem: queryservice is crashing all the time when dealing with multiple QSC. I added a small wrapper class which allows *at least* the initial queries to take place correctly, but then everything falls apart.

Summary (updated)

This patch adds basic metacontacts support to tp-contactlist. You can now add a contact to a metacontact, and have them grouped under it.

This required some tweaks to the existing queries (hey, I'm mastering SPARQL!), now the main contact query really excludes contacts belonging to a metacontact. Also, you can just specify the name of a metacontact.

At the moment, there is a blocker for this patch as Nepomuk::QueryServiceClient has a bug which makes the whole thing unusable.

Overall, it looks to me a decent start: the system already basically works.

Diffs (updated)

  /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1116160 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.h 1116160 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.cpp 1116160 
  /trunk/playground/network/telepathy-contactlist/main-widget.h 1116160 
  /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1116160 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1116160 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1116160 
  /trunk/playground/network/telepathy-contactlist/nepomuk-query-query-pool.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/nepomuk-query-query-pool.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp 1116160 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.h 1116160 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp 1116160 



Tp-contactlist handles metacontacts decently, see screenshot.


Seeing is believing



More information about the KDE-Telepathy mailing list