Review Request: Removed accounts not updated in Nepomuk

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Fri Apr 23 13:13:27 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3784/
-----------------------------------------------------------

Review request for telepathy and George Goldberg.


Summary
-------

When an account is removed from telepathy-mission-control, Nepomuk data is not updated.
This means that, for example, if last status for a removed account was online, querying Nepomuk will always return that account among other existing accounts and will always affirm that removed account is online.

This patch sets statusType property to Tp::ConnectionPresenceTypeUnset in Nepomuk before creating accounts. Later, statusType is updated only for existing accounts, not for removed ones.
Also adds "onAccountRemoved" slot that resets statusType to Tp::ConnectionPresenceTypeUnset when account is removed.


Diffs
-----

  /trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.h 1116405 
  /trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.cpp 1116405 

Diff: http://reviewboard.kde.org/r/3784/diff


Testing
-------


Thanks,

Daniele E.



More information about the KDE-Telepathy mailing list