Review Request: Start basic metacontacts support in tp-contactlist

Dario Freddi drf54321 at gmail.com
Sun Apr 18 22:10:59 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3650/
-----------------------------------------------------------

Review request for telepathy and George Goldberg.


Summary
-------

This patch adds basic metacontacts support to tp-contactlist. You can now add a contact to a metacontact, and have them grouped under it.

This required some tweaks to the existing queries (hey, I'm mastering SPARQL!), now the main contact query really excludes contacts belonging to a metacontact. Also, you can just specify the name of a metacontact.

Of course, there are some caveats.

 - The name of the metacontact is stored inside description. Any better places?
 - For any reason, when grouped under metacontacts, presence icons fail to load
 - Do we want to have t-i-d know about metacontacts and stuff? I think the current approach is sane.
 - I am assuming each contact may belong to one and only one metacontact. Is this assumption correct?
 - Some more stuff, some of which are pointed in the code.

Overall, it looks to me a decent start: the system already basically works.


Diffs
-----

  /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1116075 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-meta-contact-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.h 1116075 
  /trunk/playground/network/telepathy-contactlist/contacts-list-model.cpp 1116075 
  /trunk/playground/network/telepathy-contactlist/main-widget.h 1116075 
  /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1116075 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1116075 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1116075 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.h 1116075 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp 1116075 

Diff: http://reviewboard.kde.org/r/3650/diff


Testing
-------

Tp-contactlist handles metacontacts decently, see screenshot.


Screenshots
-----------

Seeing is believing
  http://reviewboard.kde.org/r/3650/s/365/


Thanks,

Dario



More information about the KDE-Telepathy mailing list