Review Request: Improve some small stuff in NepomukSignalWatcher

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3615/#review5092
-----------------------------------------------------------

Ship it!


Looks fine to me.

- George


On 2010-04-15 17:08:54, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3615/
> -----------------------------------------------------------
> 
> (Updated 2010-04-15 17:08:54)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> Small patch: it uses deleteLater() on the soprano model (deleting directly a QObject subclass is never a good idea), and implements a real singleton guarded by K_GLOBAL_STATIC instead of using a single static member variable.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-contactlist/nepomuk-signal-watcher.cpp 1114768 
> 
> Diff: http://reviewboard.kde.org/r/3615/diff
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Dario
> 
>