Review Request: Improve some small stuff in NepomukSignalWatcher

Dario Freddi drf54321 at gmail.com
Thu Apr 15 19:08:55 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3615/
-----------------------------------------------------------

Review request for telepathy and George Goldberg.


Summary
-------

Small patch: it uses deleteLater() on the soprano model (deleting directly a QObject subclass is never a good idea), and implements a real singleton guarded by K_GLOBAL_STATIC instead of using a single static member variable.


Diffs
-----

  /trunk/playground/network/telepathy-contactlist/nepomuk-signal-watcher.cpp 1114768 

Diff: http://reviewboard.kde.org/r/3615/diff


Testing
-------

Works


Thanks,

Dario



More information about the KDE-Telepathy mailing list