Review Request: Make telepathy-contactlist pick up Nepomuk changes real-time using new features from t-i-d

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3614/#review5094
-----------------------------------------------------------

Ship it!


Another fairly superficial review, and it looks fine.

- George


On 2010-04-18 14:09:14, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3614/
> -----------------------------------------------------------
> 
> (Updated 2010-04-18 14:09:14)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> I know you were missing me, so here's another patch.
> 
> As promised, I made tp-contactlist react in realtime to contact changes. This means t-cl is almost usable right now: added contacts are shown instantly as they get approved, and removed contacts are thrown away as they are removed as well. This thanks to the awesome QueryServiceClient.
> 
> Also, I had to add an unregister function to NepomukSignalWatcher, as by now the watcher could actually call a callback on a dangling pointer.
> 
> For finishing, now tp-contactlist only shows contacts that published their presence to us, in the same flavour empathy does. In the end, this is probably not really what we'll want to do, but it's here to show it works. With the current architecture, it's just a matter of tuning the SPARQL query retrieving contacts for deciding what will be shown: all the rest is done by magic.
> 
> Needless to say: this patch needs the latest t-i-d as found in review request #3468: failure in doing so will prompt you an empty list (and will also make compilation fail due to a change in the ontology)
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1114768 
>   /trunk/playground/network/telepathy-contactlist/contact-item.h 1114768 
>   /trunk/playground/network/telepathy-contactlist/contact-item.cpp 1114768 
>   /trunk/playground/network/telepathy-contactlist/contacts-list-model.h 1114768 
>   /trunk/playground/network/telepathy-contactlist/contacts-list-model.cpp 1114768 
>   /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1114768 
>   /trunk/playground/network/telepathy-contactlist/nepomuk-signal-watcher.h 1114768 
>   /trunk/playground/network/telepathy-contactlist/nepomuk-signal-watcher.cpp 1114768 
> 
> Diff: http://reviewboard.kde.org/r/3614/diff
> 
> 
> Testing
> -------
> 
> As usual with empathy on my side. Now tp-contactlist and empathy have the exact same behavior in contact handling. This rocks :)
> 
> 
> Thanks,
> 
> Dario
> 
>