[Kde-scm-interest] Layout of "lokalize" and "kompare" git repos with plugins integrated (was: Re: Forming repos by plugin type or code domain?)

[Jeremy Whiting]

On Wed, Dec 19, 2012 at 2:28 AM, Friedrich W. H. Kossebau
<kossebau at kde.org>wrote:

> Am Dienstag, 18. Dezember 2012, 18:07:03 schrieb Jeremy Whiting:
> > Albert,
> >
> > I got all of kdesdk subfolders to build standalone using the attached
> > (huge) patch.
>
> Good work.
>
> Hm, maybe not completely, configuring (of complete kdesdk, trunk, with
> out-of-
> source build) fails for me with:
> --- 8< ---
> CMake Error at kapptemplate/CMakeLists.txt:17 (include):
>   include could not find load file:
>
>     KAppTemplateMacro
>
>
> CMake Error at kapptemplate/templates/C++/CMakeLists.txt:17
> (kapptemplate_add_app_templates):
>   Unknown CMake command "kapptemplate_add_app_templates".
> --- 8< ---
>
> Did not investigate more, no time ATM, sorry.
>

That's very weird. it works fine here, and I just checked the file
kapptemplate/cmake/macros/KAppTemplateMacro.cmake is in the svn commit, but
isn't in the patch file somehow :/  Ok, here's a new patch created with svn
diff --show-copies-as-adds which includes it.

thanks,
Jeremy


> > I want to get someone besides myself to take a look before I
> > commit it though, but here it makes it so kdesdk can be built as one
> > module, and also each subfolder (except docs) can be built by itself.  I
> > removed quite a bit from the top level CMakeLists.txt so it's just a
> bunch
> > of add_subdirectory calls.
>
> Though that bit was in to support people who just have a few of the kdesk
> submodules checked out and not all of them. Changing this would break
> things
> for them.
>
> So I propose to leave kdesdk_optional_add_subdirectory in for now and use
> that
> instead of add_subdirectory, does not really hurt, does it? :)
>

Ah, I see, do we really expect people to have a checkout of part of kdesvn?
and if so couldn't they just build each part individually that way?  Also
it's pretty easy to comment out lines of stuff you don't want to build, I
remember doing that quite a bit when I was building kanagram over and over
when working on it years ago.


>
> > I also took out pimlibs detection and couldn't
> > find any subdir that needed/used it.  That was either in there from
> > something that has since been removed or is an optional dependency for
> > something.  If anyone knows which we may need to tweak this before
> > committing.
>
> No idea, cannot remember to have seen something.
>
> Cheers
> Friedrich
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-scm-interest/attachments/20121219/9e8e2dc5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newpatch.patch
Type: application/octet-stream
Size: 44407 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-scm-interest/attachments/20121219/9e8e2dc5/attachment-0001.obj>