[Kde-scm-interest] Layout of "lokalize" and "kompare" git repos with plugins integrated (was: Re: Forming repos by plugin type or code domain?)

[Friedrich W. H. Kossebau]

Am Mittwoch, 19. Dezember 2012, 10:24:00 schrieb Jeremy Whiting:
> On Wed, Dec 19, 2012 at 2:28 AM, Friedrich W. H. Kossebau
> 
> <kossebau at kde.org>wrote:
> > Am Dienstag, 18. Dezember 2012, 18:07:03 schrieb Jeremy Whiting:
> > > Albert,
> > > 
> > > I got all of kdesdk subfolders to build standalone using the attached
> > > (huge) patch.
> > 
> > Good work.
> > 
> > Hm, maybe not completely, configuring (of complete kdesdk, trunk, with
> > out-of-
> > source build) fails for me with:
> > --- 8< ---
> > 
> > CMake Error at kapptemplate/CMakeLists.txt:17 (include):
> >   include could not find load file:
> >     KAppTemplateMacro
> > 
> > CMake Error at kapptemplate/templates/C++/CMakeLists.txt:17
> > 
> > (kapptemplate_add_app_templates):
> >   Unknown CMake command "kapptemplate_add_app_templates".
> > 
> > --- 8< ---
> > 
> > Did not investigate more, no time ATM, sorry.
> 
> That's very weird. it works fine here, and I just checked the file
> kapptemplate/cmake/macros/KAppTemplateMacro.cmake is in the svn commit, but
> isn't in the patch file somehow :/  Ok, here's a new patch created with svn
> diff --show-copies-as-adds which includes it.

Will check in an hour, others are free to beat that :)

> > > I want to get someone besides myself to take a look before I
> > > commit it though, but here it makes it so kdesdk can be built as one
> > > module, and also each subfolder (except docs) can be built by itself.  I
> > > removed quite a bit from the top level CMakeLists.txt so it's just a
> > 
> > bunch
> > 
> > > of add_subdirectory calls.
> > 
> > Though that bit was in to support people who just have a few of the kdesk
> > submodules checked out and not all of them. Changing this would break
> > things
> > for them.
> > 
> > So I propose to leave kdesdk_optional_add_subdirectory in for now and use
> > that
> > instead of add_subdirectory, does not really hurt, does it? :)
> 
> Ah, I see, do we really expect people to have a checkout of part of kdesvn?

Sure, especially as the submodules did not have much in common. On some 
machines I only have kdesdk with okteta/.

> and if so couldn't they just build each part individually that way?

So far they could not, as the CMakeLists.txt in the top-level dir setup a few 
things (well, for those which were not yet made self-contained). This solution 
will only work after your patch (for all then).

But, it needs everyone to possibly fix things on their side (think custom 
build scripts), which could be avoided by using 
kdesdk_optional_add_subdirectory.

Let's spare everyone as much as possible needed adaption work, especially as 
there is a working solution, which really does not do any harm, besides making 
the toplevel CMakeLists.txt a little larger. There nay be quite a few people 
(think translators, so only interested in Lokalize) who build from source and 
do not follow what is happenening and what they would need to do.

There will be enough things to understand and do once the migration happened.

> Also
> it's pretty easy to comment out lines of stuff you don't want to build, I
> remember doing that quite a bit when I was building kanagram over and over
> when working on it years ago.

Now, the whole idea of optional_add_subdirectory was to allow that, to not 
need to comment out lines (and accidently commit them). kdeedu(?) might have 
missed that :)

Otherwise just add_subdirectory would have been used in kdesdk before as well.

So please keep kdesdk_optional_add_subdirectory for the time until the 
migration.

Cheers
Friedrich