[Kde-scm-interest] Layout of "lokalize" and "kompare" git repos with plugins integrated (was: Re: Forming repos by plugin type or code domain?)

Friedrich W. H. Kossebau kossebau at kde.org
Wed Dec 19 09:28:10 UTC 2012


Am Dienstag, 18. Dezember 2012, 18:07:03 schrieb Jeremy Whiting:
> Albert,
> 
> I got all of kdesdk subfolders to build standalone using the attached
> (huge) patch.

Good work.

Hm, maybe not completely, configuring (of complete kdesdk, trunk, with out-of-
source build) fails for me with:
--- 8< ---
CMake Error at kapptemplate/CMakeLists.txt:17 (include):
  include could not find load file:

    KAppTemplateMacro


CMake Error at kapptemplate/templates/C++/CMakeLists.txt:17 
(kapptemplate_add_app_templates):
  Unknown CMake command "kapptemplate_add_app_templates".
--- 8< ---

Did not investigate more, no time ATM, sorry.

> I want to get someone besides myself to take a look before I
> commit it though, but here it makes it so kdesdk can be built as one
> module, and also each subfolder (except docs) can be built by itself.  I
> removed quite a bit from the top level CMakeLists.txt so it's just a bunch
> of add_subdirectory calls. 

Though that bit was in to support people who just have a few of the kdesk 
submodules checked out and not all of them. Changing this would break things 
for them.

So I propose to leave kdesdk_optional_add_subdirectory in for now and use that 
instead of add_subdirectory, does not really hurt, does it? :)

> I also took out pimlibs detection and couldn't
> find any subdir that needed/used it.  That was either in there from
> something that has since been removed or is an optional dependency for
> something.  If anyone knows which we may need to tweak this before
> committing.

No idea, cannot remember to have seen something.

Cheers
Friedrich


More information about the Kde-scm-interest mailing list