qwhatsthis experiment

David Faure faure at kde.org
Sat Sep 11 00:15:47 CEST 2004


On Friday 10 September 2004 23:31, Carlos Leonhard Woelz wrote:
> > > 6) Send the patch to bugzilla, or to the maintainer / devel list.
> > > Bugzilla option requires more work, while the devel list  can be a black
> > > hole for patches.
> > Patches are usually applied, especially when trivial (qwhatsthis
> > additions
> > can't really break stuff).
> 
> Are you sure we can make a policy out of this? Till now, I never applied
> whatsthis direcly, I always send it to the maintainer. Even for KPilot,
> I wrote the doc in cvs, but sent the whatsthis for the whole app as a
> single patch. For whatsthis inside C++ code, this may be even more
> delicate.

Misunderstanding - I was replying to "a devel list can be a black hole".
It is my experience that devel lists are not black holes; "easy" patches
sent to devel lists get applied.

> > > One solution is that we should not check the content
> > > as a rule, only create the patches, check the spelling and guidelines
> > > conformance. The maintainer should apply the patch if he thinks it is
> > > OK, or simply drop it if it is not.
> > That solution will depend much more on whether the developer is willing
> > to
> > spend time on this. But for maintained apps this should still work imho.
> > If I get a long file with all the missing whatsthis for all the KWord
> > actions, 
> > I'll certainly spend the required time to add the C++ code for them.
> > Which means btw that it would be useful to have the strings in
> > copy-n-paste
> > ready format, i.e. with i18n() and "" and c-style line-breaking
> > (repeating the
> > double-quote at begin and end of lines)
> 
> That would not be necessary in the proposal: you would get the whatsthis
> already as a C++ or .ui patch. Then you would only decide if you want to
> apply it or if it's not good enough.

OK. I thought you were suggesting another solution where you wouldn't make
the patch, only collect the entries. If you're unable to make patches (too hard or 
too many to do), I guess it doesn't hurt checking with the maintainer if he
would be willing to do some of the work himself; as a fallback solution.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


More information about the kde-quality mailing list