D29223: Update Taiwanese holidays

[Weisi Dai]

weisi added a comment.


  I prefer this diff to the changes I took in D29373 <https://phabricator.kde.org/D29373>. I wish I had seen this diff earlier.
  
  Would you also indicate the plan for the festivals specified as "2020" in this diff for future years? For example, could you add the 2021 dates to this diff and show the suggested layout of the code? I plan to replicate this in the `cn_zh-cn` file once we agree on how to best handle those.
  
  I like the idea of referring to the law as the source, instead of potential unreliable third-party websites. But I wonder if this criteria might be too restrictive here:
  
  - On the Spring festival 春節 of 2020, the publicholidays.tw page <https://publicholidays.tw/zh/2020-dates/> and the official source listed on that page <https://www.dgpa.gov.tw/information?uid=83&pid=9713> both showed Jan 23 to 29 as the days off. Or maybe you just meant to use `length 3 days` (instead of `length 5 days`) which is what the law says <https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033>? For the future years I only put in the day of the Spring festival in D29373 <https://phabricator.kde.org/D29373> but maybe I should have marked `length 3 days`.
  - 紀念日及節日實施辦法 <https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033> as a law, may not be able to include many interesting dates - you don't really expect a law to change too frequently. So I think some festivals can still be put in this file - they are still "//day[s] that may have special significance to a fairly large number of people//" (quote from the `/DESIGN` file) after all. For example, in my opinion, Freedom of Expression Day 言論自由日 and Double Ninth Day 重陽節 (and maybe more) deserve to be put in this list.

INLINE COMMENTS

> holiday_tw_zh-tw:17
> +:name        "可選 - 預設為國家名"
> +description "中華民國（臺灣）紀念日及節日"
> +

One more space here.

> holiday_tw_zh-tw:37
> +"農曆除夕"                          public cultural on 24 January 2020
> +: Spring festival
> +"春節"                              public cultural on 25 January 2020 length 5 days

Uppercase `F`.

> holiday_tw_zh-tw:38
> +: Spring festival
> +"春節"                              public cultural on 25 January 2020 length 5 days
> +: Tomb Sweeping Day

Do you intend to use 3 days here?

According to 紀念日及節日實施辦法 <https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033>:

> 下列民俗節日，除春節放假三日外，其餘均放假一日... (3 days off for the Spring festival, 1 day off otherwise, for the following...)

> holiday_tw_zh-tw:62
> +
> +"佛陀誕辰紀念日"                    commemorative on 30 April 2020
> +

I think this one is more religious than commemorative.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29223

To: nhiga, winterz, cgiboudeaux, shrapnel
Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200503/bc3feab0/attachment-0001.html>