<table><tr><td style="">weisi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29223">View Revision</a></tr></table><br /><div><div><p>I prefer this diff to the changes I took in <a href="https://phabricator.kde.org/D29373" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29373</a>. I wish I had seen this diff earlier.</p>
<p>Would you also indicate the plan for the festivals specified as "2020" in this diff for future years? For example, could you add the 2021 dates to this diff and show the suggested layout of the code? I plan to replicate this in the <tt style="background: #ebebeb; font-size: 13px;">cn_zh-cn</tt> file once we agree on how to best handle those.</p>
<p>I like the idea of referring to the law as the source, instead of potential unreliable third-party websites. But I wonder if this criteria might be too restrictive here:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">On the Spring festival 春節 of 2020, the <a href="https://publicholidays.tw/zh/2020-dates/" class="remarkup-link" target="_blank" rel="noreferrer">publicholidays.tw page</a> and <a href="https://www.dgpa.gov.tw/information?uid=83&pid=9713" class="remarkup-link" target="_blank" rel="noreferrer">the official source listed on that page</a> both showed Jan 23 to 29 as the days off. Or maybe you just meant to use <tt style="background: #ebebeb; font-size: 13px;">length 3 days</tt> (instead of <tt style="background: #ebebeb; font-size: 13px;">length 5 days</tt>) which is <a href="https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033" class="remarkup-link" target="_blank" rel="noreferrer">what the law says</a>? For the future years I only put in the day of the Spring festival in <a href="https://phabricator.kde.org/D29373" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D29373</a> but maybe I should have marked <tt style="background: #ebebeb; font-size: 13px;">length 3 days</tt>.</li>
<li class="remarkup-list-item"><a href="https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033" class="remarkup-link" target="_blank" rel="noreferrer">紀念日及節日實施辦法</a> as a law, may not be able to include many interesting dates - you don't really expect a law to change too frequently. So I think some festivals can still be put in this file - they are still "<em>day[s] that may have special significance to a fairly large number of people</em>" (quote from the <tt style="background: #ebebeb; font-size: 13px;">/DESIGN</tt> file) after all. For example, in my opinion, Freedom of Expression Day 言論自由日 and Double Ninth Day 重陽節 (and maybe more) deserve to be put in this list.</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168119">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">:name "可選 - 預設為國家名"
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">description "中華民國（臺灣）紀念日及節日"
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">One more space here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168121">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">"農曆除夕" public cultural on 24 January 2020
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">: Spring festival
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">"春節" public cultural on 25 January 2020 length 5 days
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Uppercase <tt style="background: #ebebeb; font-size: 13px;">F</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168130">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">: Spring festival
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">"春節" public cultural on 25 January 2020 length 5 days
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">: Tomb Sweeping Day
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do you intend to use 3 days here?</p>
<p style="padding: 0; margin: 8px;">According to <a href="https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033" class="remarkup-link" target="_blank" rel="noreferrer">紀念日及節日實施辦法</a>:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">下列民俗節日，除春節放假三日外，其餘均放假一日... (3 days off for the Spring festival, 1 day off otherwise, for the following...)</p></blockquote></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29223#inline-168128">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holiday_tw_zh-tw:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">"佛陀誕辰紀念日" commemorative on 30 April 2020
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think this one is more religious than commemorative.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R175 KHolidays</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29223">https://phabricator.kde.org/D29223</a></div></div><br /><div><strong>To: </strong>nhiga, winterz, cgiboudeaux, shrapnel<br /><strong>Cc: </strong>weisi, KDE PIM, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>