D28938: DAV resource: propagate color changes to the server

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davgroupwareresource.cpp:613
> +    //job->setProperty(QStringLiteral("displayname"), collection.displayName());
> +    if (color.isValid()) {
> +        job->setProperty(QStringLiteral("calendar-color"), color.name(), QStringLiteral("http://apple.com/ns/ical/"));

If the color is not valid, the job is basically a no-op. Could that potentially cause some issues? Maybe you should just add an `else` branch that calls `changeCommitted()` and returns immediately.

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D28938

To: dfaure, dvratil, ochurlaud, vkrause, winterz, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200418/f0136a49/attachment-0001.html>