D28634: [resources] Use "/" instead of QDir::separator
Igor Poboiko
noreply at phabricator.kde.org
Mon Apr 6 19:59:59 BST 2020
poboiko created this revision.
poboiko added reviewers: dvratil, mlaurent.
Herald added a project: KDE PIM.
poboiko requested review of this revision.
REVISION SUMMARY
As Qt documentation states (https://doc.qt.io/qt-5/qdir.html#separator),
`QDir::separator()` should not be used to build file paths.
Note to reviewers: I might have confused `QStringLiteral` vs `QLatin1String` vs `QLatin1Char`
in some places, please correct me if I'm wrong
TEST PLAN
It compiles
REPOSITORY
R44 KDE PIM Runtime
BRANCH
maildir-qdir-separator (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28634
AFFECTED FILES
resources/contacts/contactsresource.cpp
resources/icaldir/icaldirresource.cpp
resources/kalarm/kalarmdir/kalarmdirresource.cpp
resources/maildir/libmaildir/maildir.cpp
resources/maildir/maildirresource.cpp
resources/mixedmaildir/mixedmaildirstore.cpp
resources/shared/singlefileresource/singlefileresourcebase.cpp
resources/vcarddir/vcarddirresource.cpp
To: poboiko, dvratil, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200406/aa043841/attachment.html>
More information about the kde-pim
mailing list