<table><tr><td style="">poboiko created this revision.<br />poboiko added reviewers: dvratil, mlaurent.<br />Herald added a project: KDE PIM.<br />poboiko requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28634">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As Qt documentation states (<a href="https://doc.qt.io/qt-5/qdir.html#separator" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qdir.html#separator</a>),<br />
<tt style="background: #ebebeb; font-size: 13px;">QDir::separator()</tt> should not be used to build file paths.</p>

<p>Note to reviewers: I might have confused <tt style="background: #ebebeb; font-size: 13px;">QStringLiteral</tt> vs <tt style="background: #ebebeb; font-size: 13px;">QLatin1String</tt> vs <tt style="background: #ebebeb; font-size: 13px;">QLatin1Char</tt><br />
in some places, please correct me if I'm wrong</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>It compiles</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R44 KDE PIM Runtime</div></div></div><br /><div><strong>BRANCH</strong><div><div>maildir-qdir-separator (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28634">https://phabricator.kde.org/D28634</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>resources/contacts/contactsresource.cpp<br />
resources/icaldir/icaldirresource.cpp<br />
resources/kalarm/kalarmdir/kalarmdirresource.cpp<br />
resources/maildir/libmaildir/maildir.cpp<br />
resources/maildir/maildirresource.cpp<br />
resources/mixedmaildir/mixedmaildirstore.cpp<br />
resources/shared/singlefileresource/singlefileresourcebase.cpp<br />
resources/vcarddir/vcarddirresource.cpp</div></div></div><br /><div><strong>To: </strong>poboiko, dvratil, mlaurent<br /><strong>Cc: </strong>kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>