D28634: [resources] Use "/" instead of QDir::separator

Laurent Montel noreply at phabricator.kde.org
Tue Apr 7 05:51:47 BST 2020


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> singlefileresourcebase.cpp:242
>          do {
> -            lostFoundFileName = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QLatin1Char('/') + identifier() + QDir::separator() + prevUrl.fileName() + QLatin1Char('-')
> +            lostFoundFileName = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/") + identifier() + QStringLiteral("/") + prevUrl.fileName() + QStringLiteral("-")
>                                  + QString::number(++i);

Why replacing QLatin1Char(..) by QStringLiteral("..") ?

> vcarddirresource.cpp:251
>  {
> -    return VcardDirResourceSettings::self()->path() + QDir::separator() + file;
> +    return VcardDirResourceSettings::self()->path() + QStringLiteral("/") + file;
>  }

Use QLatin1Char('/') everywhere

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D28634

To: poboiko, dvratil, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200407/eb5666e7/attachment-0001.html>


More information about the kde-pim mailing list