D24709: Remove some warnings about unused return values.
Laurent Montel
noreply at phabricator.kde.org
Thu Oct 17 05:50:09 BST 2019
mlaurent added a comment.
"AttachmentModel::addAttachment() always returns true (and I think that is not a mistake), and only has 1 caller I know of; maybe it should be eliminated?" if it's always return true, the return value is not useful.
"The return value from RichTextComposerSignatures::replaceSignature() is used in some places." if it's use in some place so it's important to test it too here. Perhaps adding a qCWarning when it's return false etc.
REPOSITORY
R94 PIM: Message Library
REVISION DETAIL
https://phabricator.kde.org/D24709
To: gjditchfield
Cc: mlaurent, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191017/3b06919e/attachment.html>
More information about the kde-pim
mailing list