D24709: Remove some warnings about unused return values.

[Glen Ditchfield]

gjditchfield updated this revision to Diff 68767.
gjditchfield added a comment.


  Changes based on review comments
  
  - AttachmentModel::addAttachment() always returns true, which is not useful, so change it into a void function.
  - Restore Q_REQUIRED_RESULT to RichTextComposerSignatures::replaceSignature() and add checks of the returned value where they were missing.
  - The return value of Item::appendChildItem() is potentially useful, so don't change it into a void function.  However, many current callers have no use for the returned value, so remove the Q_REQUIRED_RESULT attribute.

REPOSITORY
  R94 PIM: Message Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24709?vs=68075&id=68767

BRANCH
  retvals (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24709

AFFECTED FILES
  messagecomposer/src/attachment/attachmentmodel.cpp
  messagecomposer/src/attachment/attachmentmodel.h
  messagecomposer/src/composer-ng/autotests/richtextcomposersignaturestest.cpp
  messagelist/src/core/item.h

To: gjditchfield
Cc: mlaurent, kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20191025/d862a0ec/attachment.html>