D21036: KCalCore: Misc clang-tidy fixes

[Daniel Vrátil]

dvratil added a comment.


  Well, technically, calling the virtual methods from ctor in dtor **in those particular cases** is safe and your changes do not have any impact, since the standard says that when a ctor/dtor calls a virtual function of the object currently under construction/destruction the override called is that of the current ctor's/dtor's class - in other words, it will never call an override in a more-derived class (and calling an override in a superclass is safe, because that one is already constructed/not yet destroyed). This would only be a problem (or undefined behavior, rather) if any of those methods were pure virtual, which they are not so this might be considered a false-positive from clazy.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D21036

To: winterz, vkrause, mlaurent, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190506/ea641b8e/attachment.html>