D21036: KCalCore: Misc clang-tidy fixes

[Allen Winter]

winterz created this revision.
winterz added reviewers: vkrause, mlaurent, dvratil.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
winterz requested review of this revision.

REVISION SUMMARY
  more clang-tidy fixes:
  
    clang-analyzer-deaddode.DeadStores in recurrencerule.cpp
    clang-analyzer-optin.cplusplus.VirtualCall in calendar.cpp, freebusy.cpp, incidence.cpp, memorycalendar.cpp
    readability-redundant-control-flow in freebusy.cpp
    readability-avoid-const-params-in-decls in memorycalendar.cpp

TEST PLAN
  make && make test still work

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D21036

AFFECTED FILES
  src/calendar.cpp
  src/freebusy.cpp
  src/incidence.cpp
  src/memorycalendar.cpp
  src/recurrencerule.cpp

To: winterz, vkrause, mlaurent, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20190505/b45377bb/attachment.html>